fix: use BIC_OVERWRITE when cping static/ too
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinjasaur
commented
Jul 26, 2024
Comment on lines
+373
to
+374
| # shellcheck disable=SC2216 | ||
| echo n | cp "${args[@]}" "${SRC_DIR}"/static/. "${DEST_DIR}" |
There was a problem hiding this comment.
don't love this, but wasn't able to immediately come up with another way to accomplish it https://www.shellcheck.net/wiki/SC2216
Pinjasaur
commented
Jul 26, 2024
Comment on lines
+18
to
+19
| PANDOC_VERSION: 3.2.1 | ||
| BATS_VERSION: 1.11.0 |
There was a problem hiding this comment.
it's been a couple years...
Pinjasaur
commented
Jul 26, 2024
|
|
||
| jobs: | ||
| # Run tests. | ||
| # See also https://docs.docker.com/docker-hub/builds/automated-testing/ | ||
| test: | ||
| # in sync with Dockerfile | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
forgot to bump this when I bumped the Dockerfile 🙃
|
@mfossen if you're up for a review I'd appreciate the 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19
Initially tried to use
cpwith--no-clobber/-nto fail if trying to copy a file over that already exists. But, depending on the OS the behavior isn't consistent, particularly Ubuntu which is what I use for the Dockerfile base along with the CI runner.I pivoted to using
cp--interactive-ly andechoing innso it would fail.Also: bumped a few different versions of things.