Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making SplineInterpolator generic #1275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Feb 17, 2025

No description provided.

@cameronwhite
Copy link
Member

I don't have any real objection to the change, but I'm curious if you have a use case that benefits from using float instead?

@Lehonti
Copy link
Contributor Author

Lehonti commented Feb 20, 2025

This is a mathematical algorithm, so I wanted to make the code more 'matematically pure'. Having the numeric type abstracted out like this would make it read a bit more like a piece of mathematical reasoning (because it makes it clearer which part of the code corresponds to which part of the reasoning).

I see permissively-licensed projects like these as gifts to humankind, and having its distinct parts be clear and exemplary or at least decent reference implementations of something would give that idea some justice.

Those are my thoughts, but let me know yours :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants