Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(performances): improve scan performances #20

Merged
merged 3 commits into from
Nov 5, 2021
Merged

fix(performances): improve scan performances #20

merged 3 commits into from
Nov 5, 2021

Conversation

MayuriXx
Copy link
Collaborator

No description provided.

@MayuriXx MayuriXx requested a review from PiotrFLEURY October 15, 2021 08:51
@MayuriXx MayuriXx marked this pull request as draft October 15, 2021 08:51
@PiotrFLEURY PiotrFLEURY added bug Something isn't working enhancement New feature or request labels Oct 15, 2021
@PiotrFLEURY PiotrFLEURY added this to the 2.3.0 milestone Oct 15, 2021
This was linked to issues Oct 15, 2021
improve efficiency of camcode #18
Closed
Camcode - different notes #19
Closed
@PiotrFLEURY PiotrFLEURY modified the milestones: 2.3.0, 2.2.1 Oct 15, 2021
PiotrFLEURY
PiotrFLEURY requested changes Oct 15, 2021
View reviewed changes
Copy link
Owner

@PiotrFLEURY PiotrFLEURY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A code cleanup will be required before the merge. We are on the right way !

example/web/js/barcode.js Outdated Show resolved Hide resolved
lib/cam_code_scanner.dart Outdated Show resolved Hide resolved
lib/camcode_web.dart Outdated Show resolved Hide resolved
lib/camcode_web.dart Outdated Show resolved Hide resolved
lib/camcode_web.dart Outdated Show resolved Hide resolved
@MayuriXx MayuriXx force-pushed the fix/performances branch 5 times, most recently from 51b4fc0 to 6acc948 Compare October 26, 2021 08:08
@MayuriXx MayuriXx marked this pull request as ready for review October 26, 2021 08:08
@MayuriXx MayuriXx requested a review from PiotrFLEURY October 26, 2021 08:12
@PiotrFLEURY PiotrFLEURY merged commit 2d0887f into main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrFLEURY PiotrFLEURY PiotrFLEURY approved these changes

Assignees

@PiotrFLEURY PiotrFLEURY

@MayuriXx MayuriXx

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

Camcode - different notes improve efficiency of camcode
3 participants
@MayuriXx @PiotrFLEURY @gwaelesadeo