Fix character selection not giving the correct starter ship #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hammie
commented
Jan 7, 2024
| @@ -29,6 +29,8 @@ bool noConfirm = false; // added by MAXIMUS [confirmation dialog will be disable | |||
|
|
|||
| void InitInterface_RS(string iniName,ref itemsRef,string faceID) | |||
| { | |||
| Trace("============================================"); | |||
| Trace("InitInterface_RS, iniName = " + iniName + ", faceID = " + faceID); | |||
There was a problem hiding this comment.
Do we want to keep this trace?
| AddQuestRecord("Contact", 15); // GR: Line 13 is about Marigot governor. Line 15 is about Tia Dalma. | ||
| CloseQuestHeader("Contact"); | ||
| //END OF Justine Le Moigne’s Disappearance | ||
| //END OF Justine Le Moigne�s Disappearance |
| @@ -2137,7 +2137,7 @@ void QuestComplete(string sQuestName) | |||
|
|
|||
| case "Now_get_to_see_Petros_house": | |||
| Pchar.Quest.Captured_on_Guadeloupe.over = "yes"; | |||
| ChangeCharacterAddress(characterFromID("François de Vigny"), "None", ""); | |||
| ChangeCharacterAddress(characterFromID("Fran�ois de Vigny"), "None", ""); | |||
There was a problem hiding this comment.
I think this file is not related to the actual fix?
Should it be included?
| @@ -2524,7 +2521,7 @@ int Promote(ref char, ref gov, int iNation) | |||
| SetRank(char, iNation, curRank); // PB: was char.nations.(sNation).Rank = curRank; | |||
| GivePromotionReward(iNation); // PB | |||
| // bool NoLandGiven = ProfessionalNavyNation() != UNKNOWN_NATION && curRank < 7; | |||
| bool NoLandGiven = curRank < 7; // GR: no land for navy OR privateers until you are landed gentry | |||
| bool NoLandGiven = curRank < 7; // GR: no land for navy OR privateers until you are landed gentry if(NoLandGiven || iNation == PIRATE) | |||
There was a problem hiding this comment.
Is this if statement supposed to be in the comment?
| "We still have our blades Jack, together we can escape!", | ||
| "Devil...I knew you would say something like that! Well this sounds like as good of a plan as any other right now!", | ||
| "Ah... the Compass, I see, but as you might have noticed I'm in not much of a position to help you right now.", | ||
| "We still have our blades, Jack. Together we can escape!", |
There was a problem hiding this comment.
Should we update the translation as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.