Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take minibuffer input asynchronously #65

Merged
merged 7 commits into from
Sep 1, 2023
Merged

Take minibuffer input asynchronously #65

merged 7 commits into from
Sep 1, 2023

Conversation

Piturnah
Copy link
Owner

@Piturnah Piturnah commented Sep 1, 2023

Here we take the minibuffer input asynchronously, meaning that instead of calling take_input from within the event loop and then blocking until we have input, we instead switch to an alternative input view, providing a callback for when the input is received.

Motivation

  • Will fix the bug where resizing the terminal while in input mode messes up the borders.
  • (Hopefully) easier to follow control flow.

@Piturnah Piturnah marked this pull request as ready for review September 1, 2023 17:14
@Piturnah Piturnah merged commit 8ed5f0d into main Sep 1, 2023
2 checks passed
@Piturnah Piturnah deleted the feat/async-mbuffer branch September 1, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant