[usdviewq] Fix errors from stricter PySide2 5.15.1 checks. #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-6337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Fixes the build when building on Windows with PySide2 5.15.1
Fixes Issue(s)
To repro, build with python 3.6 with PySide2 5.15.1 installed on Windows
python.exe build_scripts\build_usd.py _install
Build will error out with the diagnostics below. This PR renames the offending components.
[10:06:07] : [Step 3/6] CUSTOMBUILD : error : E:\w\da639afa0455b478\USD\pxr\usdImaging\usdviewq\mainWindowUI.ui: Warning: The name 'attributeBrowserFrame' (QFrame) is already in use, defaulting to 'attributeBrowserFrame1'. [E:\w\da639afa0455b478_build\win64_py36_release\USD\pxr\usdImaging\usdviewq_usdviewq_pysideuifiles.vcxproj]
[10:06:07] : [Step 3/6]
[10:06:07] : [Step 3/6]
[10:06:07] : [Step 3/6]
[10:06:07] : [Step 3/6] E:\w\da639afa0455b478\USD\pxr\usdImaging\usdviewq\mainWindowUI.ui : warning : The name 'verticalLayout_7' (QVBoxLayout) is already in use, defaulting to 'verticalLayout_71'. [E:\w\da639afa0455b478_build\win64_py36_release\USD\pxr\usdImaging\usdviewq_usdviewq_pysideuifiles.vcxproj]