Bring MaterialX stdlib search paths in HdStorm on par with the ones used in MtlxPlugin #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-6909 |
|
Thank you for the change. Unfortunately we cannot directly merge your change as is, there are a handful of changes we would like to make. But we have a fix for the underlying issue based on your change that should be in dev soon. Thanks again. |
pixar-oss
pushed a commit
that referenced
this pull request
Nov 16, 2021
UsdMtlx uses the two environment variables PXR_USDMTLX_STDLIB_SEARCH_PATHS and PXR_USDMTLX_PUGIN_SEARCH_PATHS for the user to specify where to find the necessary MaterialX files. The imaging side does not do this. This change adds that behavior to HdMtlx. So now, if the location of the MaterialX provided libraries folder changes from the location originally found at runtime (stored in PXR_MATERIALX_STDLIB_DIR) the new location(s) can be indicated with PXR_MTLX_STDLIB_SEARCH_PATHS. The location(s) to any custom MaterialX files can be indicated with PXR_MTLX_PLUGIN_SEARCH_PATHS. (Based on GitHub PR #1628 by @vlasovi) Fixes #1586 (Internal change: 2197997)
lkerley
pushed a commit
to imageworks/USD
that referenced
this pull request
Jan 7, 2022
UsdMtlx uses the two environment variables PXR_USDMTLX_STDLIB_SEARCH_PATHS and PXR_USDMTLX_PUGIN_SEARCH_PATHS for the user to specify where to find the necessary MaterialX files. The imaging side does not do this. This change adds that behavior to HdMtlx. So now, if the location of the MaterialX provided libraries folder changes from the location originally found at runtime (stored in PXR_MATERIALX_STDLIB_DIR) the new location(s) can be indicated with PXR_MTLX_STDLIB_SEARCH_PATHS. The location(s) to any custom MaterialX files can be indicated with PXR_MTLX_PLUGIN_SEARCH_PATHS. (Based on GitHub PR PixarAnimationStudios#1628 by @vlasovi) Fixes PixarAnimationStudios#1586 (Internal change: 2197997)
seando-adsk
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Mar 1, 2024
UsdMtlx uses the two environment variables PXR_USDMTLX_STDLIB_SEARCH_PATHS and PXR_USDMTLX_PUGIN_SEARCH_PATHS for the user to specify where to find the necessary MaterialX files. The imaging side does not do this. This change adds that behavior to HdMtlx. So now, if the location of the MaterialX provided libraries folder changes from the location originally found at runtime (stored in PXR_MATERIALX_STDLIB_DIR) the new location(s) can be indicated with PXR_MTLX_STDLIB_SEARCH_PATHS. The location(s) to any custom MaterialX files can be indicated with PXR_MTLX_PLUGIN_SEARCH_PATHS. (Based on GitHub PR PixarAnimationStudios#1628 by @vlasovi) Fixes PixarAnimationStudios#1586 (Internal change: 2197997)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
HdStorm now uses environment variable "PXR_USDMTLX_STDLIB_SEARCH_PATHS" to set additional MaterialX stdlib search paths, which fully mimics the behaviour of MtlxPlugin.
Fixes Issue(s)
Partially addresses #1586 (MaterialX search paths are unstable not relocatable and code gen breaks when relocating libraries)