fix some signed/unsigned int comparison issues #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as well as getting rid of some warnings, also fixes potential bug where errors from readlink were not caught
pmolodo
force-pushed
the
signed_unsigned_comparison
branch
from
5db3ec5
to
c77fdef
Compare
|
This issue should be fixed in the dev branch by commit 2f1aee0. Closing this out, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
fix some signed/unsigned int comparison issues; as well as getting rid of some warnings, also fixes potential bug where errors from readlink were not caught
Included Commit(s)
LumaPictures@5db3ec5Fixes Issue(s)