set $MAYA_APP_DIR before running tests, to use a default maya profile

[pmolodo]

Description of Change(s)

in testWrapper.py, set the $MAYA_APP_DIR env var, so that maya tests run using a default user profile

Included Commit(s)

• 7187804
• f75077e

Fixes Issue(s)

• We were experiencing some crashes when running the tests on maya-2017, due to some problems with the color-management settings in the user profile

[jtran56]

Filed as internal issue #147137.

[sunyab]

Hey @elrond79, at the moment we'd prefer to keep library or plugin-specific environment variables out of testWrapper.py. Can we add MAYA_APP_DIR to the tests in usdMaya/CMakeLists.txt and pxrUsd/CMakeLists.txt instead, just like we do for MAYA_DISABLE_CIP? It's more boilerplate (which we can maybe move to a macro or something later) but it makes it less mysterious what environment is set when the tests are run.

I guess the one tricky bit is that in testWrapper.py, you can set MAYA_APP_DIR to the temporary test directory, which you can't really do in the CMakeLists.txt. However, would it work to set MAYA_APP_DIR to a relative path, like "./maya_profile" instead?

[pmolodo]

Makes sense - moved it into the CMakeLists.txt files. I checked and confirmed that maya will use relative paths for MAYA_APP_DIR. Latest commit should have these changes!

[sunyab]

Just wanted to provide an update: I tried merging these changes earlier but the Maya tests on MacOS and Windows with Maya 2017 failed with the following errors:

On MacOS:
*** Fatal Error: Failed creating directory: ./maya_profile

On Windows:
*** Fatal Error: Failed creating directory: ./maya_profile/2017/prefs/icons
(It's able to create the maya_profile directory but not a subdirectory beneath it? Weird.)

On Linux, everything worked as expected.

Running the test using an absolute path for MAYA_APP_DIR seemed to work in all cases, so it seems like support for relative paths is inconsistent at best. I wonder if another possible solution is to have testWrapper.py do some kind of substitution; for example, if it gets passed a parameter like $TESTDIR/maya_profile, it'll substitute $TESTDIR with the temporary test directory. Still thinking about this one, though.

[pmolodo]

So, I fixed it along the lines you suggested - I altered testWrapper.py to automatically replace <PXR_TEST_DIR> in any --env-var args passed into it. Decided to go with <NAME> syntax instead of $NAME because I wanted it to be distinct from env vars or CMake vars, to avoid confusion, but I don't feel strongly about that... we can use whatever syntax or var name you prefer.