APPLE: Protect IBL convolution from NaNs in textures #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8218 |
creijon
force-pushed
the
jon/dev/protect_ibl_nan
branch
2 times, most recently
from
97cd949
to
2c46da6
Compare
creijon
force-pushed
the
jon/dev/protect_ibl_nan
branch
from
2c46da6
to
5ea8d5d
Compare
2 tasks
creijon
force-pushed
the
jon/dev/protect_ibl_nan
branch
2 times, most recently
from
9434f74
to
291c7f2
Compare
creijon
force-pushed
the
jon/dev/protect_ibl_nan
branch
from
291c7f2
to
a563b69
Compare
creijon
force-pushed
the
jon/dev/protect_ibl_nan
branch
2 times, most recently
from
067cc68
to
0749280
Compare
creijon
force-pushed
the
jon/dev/protect_ibl_nan
branch
from
0749280
to
267c590
Compare
creijon
force-pushed
the
jon/dev/protect_ibl_nan
branch
from
267c590
to
9a41bf4
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
On Apple platforms with the Metal port of Storm, any NaNs in the input dome light textures will propagate through the IBL convolution calculation and cause completely black lighting. on these channels.
This doesn't seem to be a problem with openGL, but it's a small change that shouldn't have a performance hit.
Fixes Issue(s)