Autodesk: Fix for shader compile error with mx::heighttonormal nodes #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we use MaterialX heighttonormal node to convert a height map to normal map, Storm reports a shader error. error C7522: OpenGL requires constants to be initialized The root cause is that the filter kernels are uninitialized const float c_box_filter_weights[84]; const float c_gaussian_filter_weights[84]; Also logged as USD github issue PixarAnimationStudios#2281
|
Filed as internal issue #USD-8404 |
erikaharrison-adsk
changed the title
|
Tagging @klucknav for visibility. Thanks |
|
Update: Without the MaterialX PR, MacOS metal results will fail, but Windows/Linux are ok. 
FYI: @jesschimein |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use MaterialX heighttonormal node to convert a height map to normal map, Storm reports a shader error. error C7522: OpenGL requires constants to be initialized
The root cause is that the filter kernels are uninitialized
const float c_box_filter_weights[84];
const float c_gaussian_filter_weights[84];
Also logged as USD github issue #2281
Description of Change(s)
Ensure blur filters are initialized correctly by MaterialX glslfx codegen
Fixes Issue(s)