Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: Remove include of "dispatcher.h" which introduces tbb headers #2616

Merged

Conversation

erikaharrison-adsk
Copy link
Contributor

Description of Change(s)

Currently, TBB header is directly included in dispatcher.h. And when someone includes the header file colorCorrectionTask.h or taskController.h in their application, dispatcher.h is included in colorCorrectionTask.h and the TBB headers will be leaked to end users causing some compatibility issues.

In this commit, the unnecessary dispatcher.h included in colorCorrectionTask.h is removed to reduce the risk of such problems.

Fixes Issue(s)

  • N/A
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

Currently, TBB header is directly included in dispatcher.h. And when someone include the header file colorCorrectionTask.h.h or taskController.h in their App, as dispatcher.h is included in colorCorrectionTask.h, the TBB headers will be leaked to end user which causes some compatibility issues.
In this commit, the unnecessary dispatcher.h including in colorCorrectionTask.h is removed so that reduced risk of compatibility problems.
@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8616

@pixar-oss pixar-oss merged commit bccdc4d into PixarAnimationStudios:dev Nov 28, 2023
36 checks passed
@erikaharrison-adsk erikaharrison-adsk deleted the adsk/bugfix/tbbdependency branch February 7, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants