Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace BOOST_PP_SEQ defined stream overloads in vt/wrapArray.h #2748

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

nvmkuruc
Copy link
Collaborator

Description of Change(s)

wrapArray.h provided overloads for streamValue so that integral and floating point values don't have to go through TfPyRepr as an optimization. Overloads were defined by BOOST_PP_SEQ operating on a list of floating point and integral type sequences.

This PR uses if constexpr and TfMetaList to provide a boost free implementation without SFINAE.

This additionally changes _IsFinite to be inline, as the static GfHalf overload was generating unused function warnings.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8857

@pixar-oss pixar-oss merged commit f88e35c into PixarAnimationStudios:dev Nov 1, 2023
5 checks passed
@nvmkuruc nvmkuruc deleted the vtstream branch May 20, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants