Replace BOOST_PP_ITERATE with templates in makePyConstructor.h
#2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvmkuruc
force-pushed
the
makepyconstuctor
branch
6 times, most recently
from
bdbc614
to
ebfdaa5
Compare
nvmkuruc
force-pushed
the
makepyconstuctor
branch
from
ebfdaa5
to
dda59d1
Compare
|
Filed as internal issue #USD-8863 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
BOOST_PP_ITERATEwas being used to expand macros into implementations of the variousTfMakePy...utilities. Many of these can be replaced by variadic argument templates with minimal changes.InitCtorWithVarArgsused byTfMakePyCtorWithVarArgsrequired adding a little indirection to create anstd::index_sequencecapable of splitting the boost python args tuple into the C++ constructor named positional args and unnamed variable length args.Fixes Issue(s)