Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::intrusive_ptr with TfDelegatedCountPtr for VtValue #2892

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Dec 28, 2023

Description of Change(s)

(Depends on #2891)

#2891 provided a TfDelegatedCountPtr to support custom bookkeeping. This replaces the usage of boost::intrusive_ptr with TfDelegatedCountPtr in VtValue.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc force-pushed the vtintrusiveptr branch 2 times, most recently from 911c7c0 to 8bd7fce Compare December 29, 2023 03:00
@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-9123

@nvmkuruc nvmkuruc changed the title Replace boost::intrusive_ptr with TfIntrusiveTrackingPtr for VtValue Replace boost::intrusive_ptr with TfDelegatedCountPtr for VtValue Jan 23, 2024
@nvmkuruc nvmkuruc force-pushed the vtintrusiveptr branch 3 times, most recently from fe22532 to c957400 Compare January 29, 2024 21:59
@nvmkuruc nvmkuruc force-pushed the vtintrusiveptr branch 5 times, most recently from 3b18c90 to 0da043a Compare February 12, 2024 16:15
@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pixar-oss pixar-oss merged commit 094d2ba into PixarAnimationStudios:dev Mar 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants