Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::intrusive_ptr with TfDelegatedCountPtr for Sdf_Identity #2893

Merged

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Dec 28, 2023

Description of Change(s)

(Depends on #2891)

#2891 provided a TfIntrusiveTrackingPtr to support custom bookkeeping. This replaces the usage of boost::intrusive_ptr with TfDelegatedCountPtr for Sdf_Identity. As TfDelegatedCountPtr does not support implicit conversion from raw pointers, construction with explicit dispatch tags are now used.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc force-pushed the sdfidentityintrusiveptr branch from 55bd10b to 4524cb4 Compare December 28, 2023 23:11
@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-9124

@nvmkuruc nvmkuruc force-pushed the sdfidentityintrusiveptr branch 5 times, most recently from 7ddba1a to 5f1a570 Compare January 23, 2024 14:00
@nvmkuruc nvmkuruc changed the title Replace boost::intrusive_ptr with TfIntrusiveTrackingPtr for Sdf_Identity Replace boost::intrusive_ptr with TfDelegatedCountPtr for Sdf_Identity Jan 23, 2024
@nvmkuruc nvmkuruc force-pushed the sdfidentityintrusiveptr branch 2 times, most recently from e0e1e22 to 8ae3657 Compare January 30, 2024 04:08
@nvmkuruc nvmkuruc force-pushed the sdfidentityintrusiveptr branch 6 times, most recently from 40224cc to 3c4ad67 Compare February 12, 2024 16:15
@nvmkuruc nvmkuruc force-pushed the sdfidentityintrusiveptr branch from 3c4ad67 to ba44e20 Compare March 1, 2024 15:33
@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pixar-oss pixar-oss merged commit e4c8d1b into PixarAnimationStudios:dev Mar 26, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants