Autodesk: Revise test case comparison parameters to avoid false positive #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problems: As comparing test case output with baseline, the OIIO tool idiff consume a few options, e.g. -fail, -failpercent, -p (perceptual) and so on. From very begining, the options value inputs are not reasonble to catch all of pixel changes. The false positive is found when using WebGPU backend. That is, a number of cases were passed, but rendering images are not correct. The results are not real positive. Solutions: Change test input parameters to be stricter in CMake file to successfully detect errors in the generated images. Another side, remove some perceptual options they are not proper to test for specific cases.
|
Filed as internal issue #USD-9361 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Problems:
As comparing test case output with baseline, the OIIO tool idiff consume a few options, e.g. -fail, -failpercent, -p (perceptual) and so on. From very beginning, the options value inputs are not reasonable to catch all of pixel changes. The false positive is found when using an alternative hgi backend. That is, a number of cases were passed, but rendering images are not correct. The results are not real positive.
Solutions:
Change test input parameters to be stricter in CMake file to successfully detect errors in the generated images. Another side, remove some perceptual options they are not proper to test for specific cases.
Fixes Issue(s)