Autodesk: Add render-selected-edge-from-face global env var #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new global env var to switch on/off render selected edges from face
|
Filed as internal issue #USD-9644 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pixar-oss
pushed a commit
that referenced
this pull request
Sep 25, 2024
Exposed an option in HdMeshReprDesc to enable generation of surface edge ids for surface and hull geom styles which do not otherwise draw edges. This option is disabled by default. Fixes #3071 (Internal change: 2341696)
|
@erikaharrison-adsk we believe that David's commit above addresses the original issue, so we're going to close this out. Please let us know if you have further issues here! |
erikaharrison-adsk
deleted the
adsk/feature/add-global-env-render-edge-from-face
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
To improve the performance of using Geometry Shader in HdStorm, expose an environment variable to enable/disable render-selected-edge-from-face feature, which may trigger geometry shader.
In HdStorm, when rendering mesh using HdMeshGeomStyleSurf/HdMeshGeomStyleHull geomStyle, the Geometry Shader might be enabled to support the render-selected-edge-from-face feature, this could bring performance overhead if the application doesn't need that feature, so, adding an environment variable to enable/disable render-selected-edge-from-face feature in HdStorm,
Fixes Issue(s)