Autodesk: Bugfix for MaterialX shadows in Metal #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-10055 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pixar-oss
merged commit 70b526f
into
PixarAnimationStudios:release
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
See Issue #3176 for steps to reproduce. MaterialX shadows weren't appearing, but USD handles them properly.
The issue is that the MaterialX shader generation is looking for
vec3(used by Glsl) when Metal usesfloat3.https://github.com/AcademySoftwareFoundation/MaterialX/blob/de64c319eaf07e2afcae0be3dc5165d78569f008/source/MaterialXGenGlsl/Nodes/SurfaceNodeGlsl.cpp#L252
https://github.com/AcademySoftwareFoundation/MaterialX/blob/de64c319eaf07e2afcae0be3dc5165d78569f008/source/MaterialXGenMsl/Nodes/SurfaceNodeMsl.cpp#L253
Fixed files from Issue:
Fixes Issue(s)