Dev win ip #37
Dev win ip #37
Conversation
This is to help in cross platform interopability and asset sharing.
Fixed crash in ArchVStringPrintf when string is over 4K. Moved .dot files to be in temp directory.
|
Cleanup of of cmake - added PXR_HYBRID_BUILD_MODE build flag to enable symbols in release ArchGetEnv no longer uses static results (via feedback from Sunya). |
|
end-to-end example can now be completed. |
| @@ -93,6 +93,7 @@ def _AddShadingToBall(stage): | |||
| with shadingVariant.GetVariantEditContext(): | |||
| whichBall = variantName.split('_')[-1] | |||
| texPath = os.path.join(texDir, 'ball%s.tex' % whichBall) | |||
| texPath = texPath.replace('\\', '/') | |||
| # in the current variant, modify the color | |||
There was a problem hiding this comment.
Might be an idea here to expose the path normalizer you wrote earlier via Python and call that here instead ~ then normalization will behave the same everywhere. Then it would cover drive letter upper-lower-casing etc...
There was a problem hiding this comment.
I'm not sure I understand Nick. Are you saying the tutorial script should have a dependency on Tf?
There was a problem hiding this comment.
I guess yeah. It's a tutorial so maybe it's not that important, but I was thinking that it's probably good that normalization is consistent everywhere, especially if the rules ever get more complex. For example, at ILM, we had scripts that performed much more stringent normalization including illegal character substitutions. If it all goes through one place, that's enabled universally.
There was a problem hiding this comment.
Nick, I totally agree with you but lets discuss this offline.
There was a problem hiding this comment.
Sure thing! Anyway, I'm not suggesting that a merge be gated by my comment. It's only a comment ;)
| GarchGLWContextState::GarchGLWContextState() : | ||
| device(wglGetCurrentDC()), | ||
| context(wglGetCurrentContext()), |
Clean up of Arch based off Sunya's feedback.
Windows now uses forward slashes in all paths.