Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usdview] Added currentFrame command line argument #832

Merged

Commits on Apr 25, 2019

  1. [usdview] Added currentFrame command line argument - added help strin…

    …gs to startFrame and lastFrame.
    
        --ff FIRSTFRAME       Set the first frame of the viewer
        --lf LASTFRAME        Set the last frame of the viewer
        --cf CURRENTFRAME     Set the current frame of the viewer
    
    * Refactored setFrame to _setFrameIndex
      * Removed the closestFrame lookup - as far as I'm aware this does nothing of value as closestFrame always equals frame.
        * This has given us a speed increase on playback - the closestFrame lookup iterated over the entire _timeSamples list every time the frame changed.
      * Removed the need for the forceUpdate variable.
    
    * Re-purposed setFrame to be a simple wrapper that finds a frameIndex and calls _setFrameIndex.
    
    * Found bug where resetting of the timeline would also not update the dataModel - so the value on the timeline and what was being shown in the viewer would not match up.
      * This was fixed by adding a call to setFrame in _UpdateTimeSamples
    Ian Lawson committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    e822bcd View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. Addressed pull request comments.

    Ian Lawson committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    3f905fb View commit details
    Browse the repository at this point in the history