[usdGeom] added support for indexed uint primvar values

[AlexSchwank]

Description of Change(s)

Added support for indexed primvar values of type uint[].

testUsdGeomPrimvar.py could be extended to include a test for this in test_PrimvarsAPI() but not sure if that's necessary.

# make sure UIntArray can be used for indexed primvar values
uint_array = gp_pv.CreatePrimvar('uint_array', Sdf.ValueTypeNames.UIntArray)
uint_values = Vt.UIntArray([3, 1, 4])
uint_array.Set(uint_values)
indices = Vt.IntArray([0, 1, 2, 1, 2, 0])
uint_array.SetIndices(indices)
self.assertFalse(uint_array.ComputeFlattened() is None)

[spiffmon]

Hi Alex, sorry my other mail didn’t reach you first - we’d prefer not to go in this direction; we want indices to have a fixed type.

On Fri, May 31, 2019 at 7:10 AM AlexSchwank ***@***.***> wrote: Description of Change(s) Added support for indexed primvar values of type uint[]. *testUsdGeomPrimvar.py* could be extended to include a test for this in *test_PrimvarsAPI()* but not sure if that's necessary. # make sure UIntArray can be used for indexed primvar values uint_array = gp_pv.CreatePrimvar('uint_array', Sdf.ValueTypeNames.UIntArray) uint_values = Vt.UIntArray([3, 1, 4]) uint_array.Set(uint_values) indices = Vt.IntArray([0, 1, 2, 1, 2, 0]) uint_array.SetIndices(indices) self.assertFalse(uint_array.ComputeFlattened() is None) ------------------------------ You can view, comment on, or merge this pull request online at: #861 Commit Summary - added support for indexed uint primvar values File Changes - *M* pxr/usd/lib/usdGeom/primvar.cpp <https://github.com/PixarAnimationStudios/USD/pull/861/files#diff-0> (1) Patch Links: - https://github.com/PixarAnimationStudios/USD/pull/861.patch - https://github.com/PixarAnimationStudios/USD/pull/861.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#861>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPOU2DLTJASOBTGNWRFA63PYEWWXANCNFSM4HR3CVOQ> .

-- --spiffiPhone

[AlexSchwank]

The alembic issues are with the index arrays. But this PR doesn't fix that. It adds support for uint[] for the value arrays. Is that a problem for you too?

[spiffmon]

Sorry, @AlexSchwank - I phoned that in without looking at the change. Given that at least Katana pxrUsdIn handles uint primvar arrays (lossily, as it does VtArray...), this change seems fine to me.

[AlexSchwank]

No worries, too many similar uint tickets :)
Great, thanks.

[jilliene]

Filed as internal issue #USD-5347