Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(events update): unable to mark visitor as unexpected #122

Merged
merged 2 commits into from
Sep 28, 2021
Merged

fix(events update): unable to mark visitor as unexpected #122

merged 2 commits into from
Sep 28, 2021

Conversation

stakach
Copy link
Member

@stakach stakach commented Sep 28, 2021

after marking them as expected

@stakach stakach requested a review from w-le September 28, 2021 07:29
@w-le w-le requested a review from tassja September 28, 2021 07:40
@w-le w-le added the type: bug something isn't working label Sep 28, 2021
w-le
w-le approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@w-le w-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've not tested, but at surface level the code change looks like it should work ok

@stakach stakach merged commit 8d78b96 into master Sep 28, 2021
@stakach stakach deleted the fix-removing-visit-expected branch September 28, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w-le w-le w-le approved these changes

@tassja tassja Awaiting requested review from tassja

Assignees
No one assigned
Labels
type: bug something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stakach @w-le