Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bookings): handle additional state transitions #157

Merged
merged 6 commits into from
Feb 22, 2022
Merged

fix(bookings): handle additional state transitions #157

merged 6 commits into from
Feb 22, 2022

Conversation

chillfox
Copy link
Contributor

@chillfox chillfox commented Feb 16, 2022 •
edited
Loading

Handle additional state transitions mentioned in #143 (comment) and refactor tests.

Specs:

  • booking reserved and no_show
  • booking deleted before booking_start
  • booking deleted between booking_start and booking_end
  • booking rejected before booking_start
  • booking checked_in before booking_start
  • booking checked_in and checked_out before booking_start
  • booking checked_in and checked_out between booking_start and booking_end
  • booking checked_in but never checked_out between booking_start and booking_end

@chillfox chillfox self-assigned this Feb 16, 2022
@chillfox chillfox linked an issue Feb 16, 2022 that may be closed by this pull request
Expose booking state and add booking history #143
Closed
@chillfox chillfox marked this pull request as ready for review February 16, 2022 03:40
stakach
stakach approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach stakach merged commit ec7ef2c into master Feb 22, 2022
@stakach stakach deleted the fix/booking_state_history branch February 22, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakach stakach stakach approved these changes

@caspiano caspiano caspiano approved these changes

Assignees

@chillfox chillfox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose booking state and add booking history
3 participants
@chillfox @stakach @caspiano