Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outlook): generate plugin xml manifest #208

Merged
merged 13 commits into from
Oct 19, 2022
Merged

Conversation

chillfox
Copy link
Contributor

No description provided.

@chillfox chillfox self-assigned this Aug 22, 2022
@chillfox chillfox linked an issue Aug 22, 2022 that may be closed by this pull request
@github-actions github-actions bot added the type: enhancement new feature or request label Aug 22, 2022
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 22, 2022
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 22, 2022
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 22, 2022
@chillfox chillfox marked this pull request as ready for review August 22, 2022 02:39
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 22, 2022
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one minor change


get("/manifest.xml") do
manifest = OutlookManifest.new(
app_domain: "#{App::PLACE_URI}/outlook/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want to use App::PLACE_URI this is for internal comms between the containers
we need to use the current tenant.domain and only if tenant.platform == "office365"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, can we get the tenant domain and platform without auth?
There is a requirement for the xml manifest to be served without auth.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could make the tenant part of the path, or a query param

Copy link
Member

@stakach stakach Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't need auth, just can't use the helper (I wasn't aware the helper had the extra check either)

domain_host = request.hostname.as(String)
tenant = Tenant.query.find { domain == domain_host }

@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 22, 2022
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 22, 2022
@chillfox chillfox requested a review from stakach August 22, 2022 05:53
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's hold off merging until the XML is finalised
@jeremyw24 to notify of any further changes required

@stakach
Copy link
Member

stakach commented Oct 7, 2022

@jeremyw24 any additional XML changes now that the office plugin is working?

@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Oct 19, 2022
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Oct 19, 2022
@chillfox
Copy link
Contributor Author

@stakach
Since your last review of this the following changes has been made:

  • updated xml
  • added outlook_config json column to tenants for storing config.

@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Oct 19, 2022
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Oct 19, 2022
@chillfox chillfox requested a review from stakach October 19, 2022 07:23
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Oct 19, 2022
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Oct 19, 2022
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, looking good!

@stakach stakach merged commit 0c16a90 into master Oct 19, 2022
@stakach stakach deleted the feat/outlook_manifest branch October 19, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically generate manifest.xml for outlook plugin
2 participants