Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(visitor_checkin): when running in delegated permissions mode #233

Merged
merged 9 commits into from
Oct 25, 2022

Conversation

stakach
Copy link
Member

@stakach stakach commented Oct 21, 2022

reduces reliance on obtaining the host event when running against office365

@stakach stakach requested a review from chillfox October 21, 2022 01:24
@stakach stakach self-assigned this Oct 21, 2022
@github-actions github-actions bot added the type: bug something isn't working label Oct 21, 2022
Comment on lines +571 to +573
rescue PlaceCalendar::Exception
# we might not have access
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume not doing anything here is intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I'll remove this extra query eventually

Copy link
Contributor

@chillfox chillfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Oct 21, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Oct 21, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Oct 23, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Oct 24, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Oct 25, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Oct 25, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Oct 25, 2022
@stakach stakach merged commit 9283806 into master Oct 25, 2022
@stakach stakach deleted the fix-delegated-visitor-checkin branch October 25, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants