Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outlook): minor manifest fixes #235

Merged
merged 9 commits into from
Nov 2, 2022
Merged

fix(outlook): minor manifest fixes #235

merged 9 commits into from
Nov 2, 2022

Conversation

chillfox
Copy link
Contributor

@chillfox chillfox commented Oct 27, 2022 •
edited
Loading

  • set version to a timestamp of when the config was changed
  • treat blank strings as nil (use the default config)
  • move VersionOverrides
  • set bt:Sets min version to 1.6

@chillfox chillfox self-assigned this Oct 27, 2022
@github-actions github-actions bot added the type: bug something isn't working label Oct 27, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Oct 27, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Oct 27, 2022
@chillfox chillfox marked this pull request as ready for review October 27, 2022 03:47
@chillfox chillfox requested a review from stakach October 27, 2022 03:47
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Oct 27, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Nov 2, 2022
stakach
stakach approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chillfox
Copy link
Contributor Author

chillfox commented Nov 2, 2022

@stakach
Do you know why it is all of a sudden failing to build with an error of Error: undefined local variable or method 'close_code' for HTTP::WebSocket?

@stakach
Copy link
Member

stakach commented Nov 2, 2022

Yeah, need to add this to shard override https://github.com/PlaceOS/rest-api/blob/master/shard.override.yml#L19-L21
this is the pull wyhaines/opentelemetry-instrumentation.cr#26 I'm waiting on

@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Nov 2, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Nov 2, 2022
@chillfox chillfox merged commit 6736f58 into master Nov 2, 2022
@chillfox chillfox deleted the fix/outlook_config_version branch November 2, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakach stakach stakach approved these changes

Assignees

@chillfox chillfox

Labels
type: bug something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chillfox @stakach