feat(survey): [PPT-67|PPT-101] update /surveys/questions endpoint

[chillfox]

Get endpoint for survey questions:

• Filter on deleted

Update endpoint for survey questions:

• Update the question if there are NO linked answers.
• Create a new question if there are linked answers.
• Soft-delete the question if there are linked answers.

Delete endpoint for survey questions:

• Delete the question if there are NO linked answers.
• Soft-delete the question if there are linked answers.

[naqvis]

I'm having hard time in understanding the logic here. We are updating the field in database, but mutating ivars to represent state which is different from db.

[chillfox]

question_model.persisted? is true if the model is in the database.

Survey::Answer.query.where(question_id: question_model.id).count > 0 is true if there are any linked answers.

So if the model is in the database and there are linked answers, then:

• question_model.soft_delete we mark it as deleted
• question_model.clear_persisted clears the persistent state so that our changed model gets inserted as a new row in the database and gets a new id.

By doing this we ensure that questions with linked answers are never changed as changing the question could change the meaning of the answers.

[chillfox]

Basically, Clear does not have the ability to cancel update/insert in the lifecycle hooks, so you either have to work around that or move the logic to the controllers (putting it in the controllers, feels like a future bug waiting to happen).

[chillfox]

question_model.soft_delete uses Clear::SQL.execute Clear::SQL.raw(...) to bypass the lifecycle hooks. If it did not bypass the lifecycle hooks then it would create an infinite loop.

[naqvis]

LGTM