Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bookings): [PPT-1215] allow users to add themselves as attendees to public events #316

Merged
merged 42 commits into from
Apr 18, 2024
Merged

feat(bookings): [PPT-1215] allow users to add themselves as attendees to public events #316

merged 42 commits into from
Apr 18, 2024

Conversation

chillfox
Copy link
Contributor

@chillfox chillfox commented Mar 8, 2024

No description provided.

@chillfox chillfox self-assigned this Mar 8, 2024
@github-actions github-actions bot added the type: enhancement new feature or request label Mar 8, 2024
@chillfox chillfox changed the title feat(bookings): [PPT-1215] feat(bookings): [PPT-1215] allow users to add themselves as attendees to public events Mar 8, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Mar 8, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Mar 12, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Mar 20, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Mar 22, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Mar 22, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Mar 22, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Mar 22, 2024
@github-actions github-actions bot removed the type: enhancement new feature or request label Mar 22, 2024
@github-actions github-actions bot added the type: enhancement new feature or request label Apr 9, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Apr 9, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Apr 9, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Apr 9, 2024
@chillfox chillfox marked this pull request as ready for review April 9, 2024 05:37
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Apr 15, 2024
@chillfox chillfox requested review from stakach and naqvis April 15, 2024 05:30
naqvis
naqvis reviewed Apr 17, 2024
View reviewed changes
src/controllers/bookings.cr Outdated Show resolved Hide resolved
naqvis
naqvis reviewed Apr 17, 2024
View reviewed changes
src/controllers/bookings.cr Outdated Show resolved Hide resolved
naqvis
naqvis reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@naqvis naqvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix suggested areas to avoid raises. Also please make linter happy

@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Apr 17, 2024
@chillfox
Copy link
Contributor Author

Thanks @naqvis
I have fixed the suggested code and the ameba warning.

naqvis
naqvis approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@naqvis naqvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chillfox chillfox merged commit 29ab124 into master Apr 18, 2024
11 checks passed
@chillfox chillfox deleted the PPT-1215-implement-methods-for-frontend-to-create-manage-events branch April 18, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naqvis naqvis naqvis approved these changes

@stakach stakach Awaiting requested review from stakach

Assignees

@chillfox chillfox

Labels
type: enhancement new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chillfox @naqvis