Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bookings): query within extension_data json #84

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Conversation

tassja
Copy link
Contributor

@tassja tassja commented Jul 26, 2021

Closes #81

@tassja tassja requested a review from stakach July 26, 2021 04:00
@tassja tassja self-assigned this Jul 26, 2021
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just the one concern

src/models/booking.cr Outdated Show resolved Hide resolved
@tassja tassja requested a review from stakach July 28, 2021 02:22
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tassja tassja merged commit c047fc1 into master Jul 29, 2021
@tassja tassja deleted the filter-ext-data branch July 29, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(GET bookings): allow filtering on booking.extension_data
3 participants