Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utilities helper): list calendars only as required #93

Merged
merged 1 commit into from
Aug 4, 2021
Merged

fix(utilities helper): list calendars only as required #93

merged 1 commit into from
Aug 4, 2021

Conversation

stakach
Copy link
Member

@stakach stakach commented Aug 4, 2021

this is a security feature, but the call isn't required for each request

@stakach
fix(utilities helper): list calendars only as required
cf72453 
this is a security feature, but the call isn't required for each request
@stakach stakach requested review from kimburgess and w-le August 4, 2021 06:15
@w-le w-le mentioned this pull request Aug 4, 2021
Closed
w-le
w-le approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@w-le w-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks that looks like it should work

@w-le w-le linked an issue Aug 4, 2021 that may be closed by this pull request
latest staff-api > MS Graph > list events results in 500. Tenant ID is invalid #90
Closed
@w-le
Copy link
Contributor

w-le commented Aug 4, 2021 •
edited
Loading

sidenote: looks like this would fix/optimise List Guests as well
https://github.com/place-labs/staff-api/blob/ad1d9ee531dccb220de75fb13f3d375cb3963e9e/src/controllers/guests.cr#L26

@stakach stakach merged commit 50f64c1 into master Aug 4, 2021
@stakach stakach deleted the fix-needless-calendars-requests branch August 4, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w-le w-le w-le approved these changes

@kimburgess kimburgess Awaiting requested review from kimburgess

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

latest staff-api > MS Graph > list events results in 500. Tenant ID is invalid
2 participants
@stakach @w-le