Add sword variants #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Plastix Thoughts on this? I do like the short versions, and I know they are popular among PvPers these days.
|
|
I like these — Go for it! Thanks for the heads up.
…On Wed, Dec 21, 2022, 1:30 PM Christoffer Tibell ***@***.***> wrote:
@Plastix <https://github.com/Plastix> Thoughts on this?
I do like the short versions, and I know they are popular among PvPers
these days.
I have a suggestion; the sword in this PR has a different point than the
regular sword. What about making the point look more like the regular
sword? See the embedded image as an example.
[image: image]
<https://user-images.githubusercontent.com/1613137/208977840-5fe88d9f-0834-4157-bc2b-52c051b47f25.png>
—
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALUYYMS3Q2AAUISPLVCYZTWONEFBANCNFSM6AAAAAATDYNPX4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Brottweiler I've made an update that follows your suggestion. While I do prefer the more rounded edge, it is absolutely true that these ones are probably better fitting as they look closer to their original counterparts. Let me know what you think! Thanks 👍 |
Brottweiler
approved these changes
Dec 22, 2022
|
Looks good! Thanks for this. I will add a contribution to the changelog and readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates 2 folders in the
customizationsdirectory, which contain alternate variants for sword items.short_swords
Takes the regular swords from PlastPack but removes a few pixels at the top. These changes are pretty common in PvP resource packs, and I've been asked by other people who use this pack to share these shorter versions (which is what gave me the idea for this pull request, really).
octc_swords
These ones are a bit different: They are also shorter swords, but they're based on the swords featured in the Overcast logo (mixed in with PlastPack's slimmer designs).
I've been privately using these variants for a while, but as this pack already contains alternate textures for other things, I thought they could make a good addition!