Unit Test Documentation #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhazen
added
documentation
paulhazen
requested review from
WispyMouse,
arthur740212 and
andrew-hirata-playeveryware
WispyMouse
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Seems good. Some tiny suggetions. My main takeaway from this is to have a single assert section, rather than "arrange, act, assert, arrange, act, assert". I think some my existing tests will need to broken down, then.
- Create a file, upload it. Test only this.
- Do the above without asserting. Download it. Test only this.
etc
paulhazen
commented
Sep 18, 2024
andrew-hirata-playeveryware
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces documentation regarding unit tests for the project.
#EOS-1903