-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger for Game Server API #393
Swagger for Game Server API #393
Conversation
cmd/gameserverapi/main.go
Outdated
@@ -144,6 +157,15 @@ func listGameServeBuilds(c *gin.Context) { | |||
} | |||
} | |||
|
|||
// @Summary get a game server build by buildName and namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we call them "GameServer" and "GameServerBuild" to be consistent with the rest of the documentation? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, will do! Thanks @dgkanatsios for checking it out, created this draft PR for early feedback!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgkanatsios - Could you help with this error - "go utils need to be executed", which go-utils to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the step in the pipeline that shows which utilities are executed. https://github.com/PlayFab/thundernetes/blob/main/.github/workflows/unit-tests.yml#L29
Resolves #160 |
@dgkanatsios - I have uploaded the changes here, if you want to check it out - http://20.244.70.222:5001/swagger/index.html |
I can see it, nice, thank you! |
Full list is now available at - http://20.244.70.222:5001/swagger/index.html, check it out and let me know if any changes are required. |
LGTM! Can you also make a PR to the documentation with instructions for folks to generate and access the swagger file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgkanatsios - Done, please check here - #397 |
Live demo here - http://20.244.70.222:5001/swagger/index.html