Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The way Item stacks get merged can cause an incredibly long runtime i…
…f there is a large amount of times. this can take hours or days if the ItemStack array is large enough. This doesn’t happen during regular gameplay. But it can be caused by crafting continuously with a mod like Itemscroller. Like this the main Consumer while loop gets stuck in the merge. (as it causes 100k+ stacks to be processed) This causes an indefinite (depending on how long you crafted) halt of all database pushes. This can not only render these mods basically unusable, but it also generates a memory leek (as the que is stacked up) and also prevents logging till the merge is done. which, not only prevents proper restarts, but can also lose data when forcefully restarted.
- Loading branch information
78dd534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: the stack ends up in the first occurrence not in the last
78dd534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: Because of "c2 > c1" this issue is false. It ends up in the first occurrence in either cases.