Update Traditional Chinese translation #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ianiiaannn |
|
The problem with replacing the colon with a separate space (": "), with the "：" character, is that the backend translation processing on the web server will then replace it with an ":" character... but then we'll be missing a space. So ideally, we should just keep a standard colon. Rest of the changes should be fine though. |
Intelli
requested changes
Jul 17, 2023
U5B
pushed a commit
to U5B/CoreProtect
that referenced
this pull request
Sep 22, 2023
* Update Phrase to make strings correctly split by fullwidth colons (U+FF1A) * Fix Traditional Chinese translation * Replace U+FF1A with `: `
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the formatting issues metioned in #54 by replace U+FF1A after replacing regular colon.
