Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Thread Creation to ThreadFactory for better Thread namings #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ByteExceptionM
Copy link
Contributor

@ByteExceptionM ByteExceptionM commented Oct 28, 2023

In this pull request, I've made a significant change to the way threads are created. Instead of using the default thread naming convention, which results in generic names like Thread-XX, I've implemented a ThreadFactory to assign meaningful names to threads.

This change is highly beneficial for several reasons:

Improved Debugging and Maintenance:
Named threads provide clear and informative identifiers, making it significantly easier to identify the purpose and origin of a specific thread during debugging and code maintenance. It reduces the ambiguity associated with generic thread names and simplifies the troubleshooting process.

Enhanced Logging and Monitoring:
When threads are assigned meaningful names, the logs and monitoring tools can display more informative and human-readable information. This is especially valuable in a multi-threaded Minecraft Servers, where tracking thread activity is crucial for performance optimization and issue identification.

My IDE has also refactored the imports, if this is a problem, let me know!

Signed-off-by: ByteExceptionM <git@byteexception.eu>
Copy link

stale bot commented Dec 27, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 27, 2023
@Intelli Intelli removed the stale label Dec 27, 2023
Copy link

stale bot commented Feb 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 29, 2024
@Intelli Intelli removed the stale label Feb 29, 2024
Copy link

stale bot commented May 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 2, 2024
@Intelli Intelli removed the stale label May 2, 2024
Copy link

stale bot commented Jul 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 2, 2024
@Intelli Intelli removed the stale label Jul 2, 2024
Copy link

stale bot commented Sep 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 1, 2024
@Intelli Intelli removed the stale label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants