Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: folia check to be compatible with shreddedpaper #551

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

ProdPreva1l
Copy link
Contributor

ShreddedPaper is fully compatible with all folia plugins if don't check if its folia, BUT we have an empty class for RegionizedServer as MOST plugins will check for this, please be like everyone else!

ShreddedPaper is fully compatible with all folia plugins if don't check if its folia, BUT we have an empty class for RegionizedServer as MOST plugins will check for this, please be like everyone else!
@Intelli
Copy link
Contributor

Intelli commented Jun 5, 2024

CoreProtect’s Folia check can be found here:

Class.forName("io.papermc.paper.threadedregions.ThreadedRegionizer");

@Intelli Intelli closed this Jun 5, 2024
@ProdPreva1l
Copy link
Contributor Author

ProdPreva1l commented Jun 8, 2024

CoreProtect’s Folia check can be found here:

Class.forName("io.papermc.paper.threadedregions.ThreadedRegionizer");

lol ik thats why i modified it to use a more conventional class so that core protect can be compatible with more servers without you needing to do anything, this is a PR not an issue, maybe check the edited files next time ;)

@Intelli
Copy link
Contributor

Intelli commented Jun 8, 2024

Oh yeesh, going through things too quickly and didn’t even notice this was a PR.

That change is fine.

@Intelli Intelli reopened this Jun 8, 2024
@Intelli Intelli merged commit d2edace into PlayPro:master Jun 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants