wal should unlock hanged locks #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aloren
reviewed
May 20, 2019
| deleteWalTransaction(transactionId); | ||
| } | ||
|
|
||
| void releaseLocks(Set<Key> keysLocked) throws BackendException { |
There was a problem hiding this comment.
it's overridden in test implementation: FlakingAerospikeStoreManager
Aloren
reviewed
May 20, 2019
| logger.info("Failed to complete transaction id={}", | ||
| transaction.transactionId, be); | ||
| catch (PermanentLockingException be) { | ||
| logger.info("Failed to complete transaction id={} as it's already completed", transaction.transactionId, be); |
There was a problem hiding this comment.
if this is ok case why do we need to log that on info level? debug should be enough then
There was a problem hiding this comment.
yes. It's expected but quite rare corner case. So want to log it with info level to know the frequency of this cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.