Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA-48685 : Analyze transaction locks more thoughtfully #41

Merged
merged 3 commits into from
Jul 17, 2019

Conversation

kptfh
Copy link
Collaborator

@kptfh kptfh commented Jul 12, 2019

No description provided.

@tdanylchuk
Copy link

no chance to add tests?

@kptfh kptfh force-pushed the feature/INFRA-48685-WAL-Completer-should-release-locks branch from 4c7c930 to c968c1d Compare July 17, 2019 14:12
@kptfh kptfh force-pushed the feature/INFRA-48685-WAL-Completer-should-release-locks branch from c968c1d to 2424177 Compare July 17, 2019 14:51
@codecov-io
Copy link

Codecov Report

Merging #41 into develop will decrease coverage by 1.02%.
The diff coverage is 88.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #41      +/-   ##
============================================
- Coverage      87.33%   86.3%   -1.03%     
- Complexity       174     182       +8     
============================================
  Files             13      15       +2     
  Lines            671     701      +30     
  Branches          63      65       +2     
============================================
+ Hits             586     605      +19     
- Misses            57      65       +8     
- Partials          28      31       +3
Impacted Files Coverage Δ Complexity Δ
.../playtika/janusgraph/aerospike/util/AsyncUtil.java 72.41% <0%> (ø) 9 <0> (ø) ⬇️
...nusgraph/aerospike/wal/WriteAheadLogCompleter.java 83.11% <100%> (ø) 13 <0> (ø) ⬇️
...janusgraph/aerospike/wal/WriteAheadLogManager.java 97.61% <100%> (+0.15%) 17 <2> (ø) ⬇️
...sgraph/aerospike/AerospikeKeyColumnValueStore.java 89% <100%> (+1.74%) 27 <4> (+1) ⬆️
.../janusgraph/aerospike/TransactionalOperations.java 96.92% <100%> (+0.09%) 24 <1> (ø) ⬇️
...m/playtika/janusgraph/aerospike/ConfigOptions.java 91.66% <100%> (ø) 1 <0> (ø) ⬇️
...usgraph/aerospike/TestAerospikePolicyProvider.java 100% <100%> (ø) 3 <3> (?)
.../janusgraph/aerospike/AerospikePolicyProvider.java 69.23% <69.23%> (ø) 3 <3> (?)
...ka/janusgraph/aerospike/AerospikeStoreManager.java 82.43% <75%> (-1.78%) 20 <1> (+1)
.../playtika/janusgraph/aerospike/LockOperations.java 86.8% <87.5%> (-2.33%) 38 <9> (+1)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e9c73...8ce3c4a. Read the comment docs.

@kptfh kptfh merged commit 518c430 into develop Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants