Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactoring #48

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Feature/refactoring #48

merged 2 commits into from
Aug 8, 2019

Conversation

kptfh
Copy link
Collaborator

@kptfh kptfh commented Aug 7, 2019

Refactored to separate operation classes

@kptfh kptfh force-pushed the feature/refactoring branch from 9fd42df to 6c0027b Compare August 8, 2019 07:26
@codecov-io
Copy link

Codecov Report

Merging #48 into develop will increase coverage by 1.31%.
The diff coverage is 95.57%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #48      +/-   ##
=============================================
+ Coverage       86.3%   87.61%   +1.31%     
- Complexity       182      217      +35     
=============================================
  Files             15       23       +8     
  Lines            701      751      +50     
  Branches          65       65              
=============================================
+ Hits             605      658      +53     
+ Misses            65       61       -4     
- Partials          31       32       +1
Impacted Files Coverage Δ Complexity Δ
...aph/aerospike/operations/AerospikeKeyIterator.java 65.45% <ø> (ø) 12 <0> (?)
.../playtika/janusgraph/aerospike/util/AsyncUtil.java 72.22% <0%> (-0.2%) 6 <0> (-3)
...rospike/transaction/WriteAheadLogManagerBasic.java 96.15% <100%> (ø) 16 <2> (?)
...ph/aerospike/operations/BasicMutateOperations.java 100% <100%> (ø) 15 <15> (?)
...sgraph/aerospike/AerospikeKeyColumnValueStore.java 85.71% <100%> (-3.29%) 13 <7> (-14)
.../aerospike/transaction/WriteAheadLogCompleter.java 83.11% <100%> (ø) 13 <1> (?)
...ph/aerospike/transaction/WriteAheadLogManager.java 100% <100%> (ø) 0 <0> (?)
...anusgraph/aerospike/operations/LockOperations.java 100% <100%> (ø) 0 <0> (?)
...ika/janusgraph/aerospike/AerospikeTransaction.java 100% <100%> (ø) 12 <7> (+7) ⬆️
...anusgraph/aerospike/operations/ScanOperations.java 100% <100%> (ø) 4 <4> (?)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50de95...6c0027b. Read the comment docs.

@kptfh kptfh merged commit ab360fd into develop Aug 8, 2019
@kptfh kptfh deleted the feature/refactoring branch August 8, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants