batch reads options added #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdanylchuk
reviewed
Sep 25, 2019
| } | ||
|
|
||
| public Map<StaticBuffer,EntryList> getSlice(String storeName, List<StaticBuffer> keys, SliceQuery query, StoreTransaction txh) throws BackendException { | ||
| if(keys.size() == 1){ | ||
| StaticBuffer key = keys.get(0); |
There was a problem hiding this comment.
due to abstraction level better to extract get single element logic to separate method
| return Collections.singletonMap(key, | ||
| getSlice(storeName, new KeySliceQuery(key, query.getSliceStart(), query.getSliceEnd()), txh)); | ||
| } else if(keys.size() < bathReadThreshold){ | ||
| return getSliceParallel(storeName, keys, query, txh); |
There was a problem hiding this comment.
i'd rather rename it to getSliceInParallel
| } | ||
| } | ||
|
|
||
| public Map<StaticBuffer,EntryList> getSliceBatch(String storeName, List<StaticBuffer> keys, SliceQuery query, StoreTransaction txh) throws BackendException { |
There was a problem hiding this comment.
i'd rather rename it to getSliceByBatch
| final EntryArrayList result = new EntryArrayList(); | ||
| entriesMap.entrySet().stream() | ||
| .limit(entriesNo) | ||
| .forEach(entry -> { |
There was a problem hiding this comment.
we can use here collect(customCollector())
kptfh
force-pushed
the
feature/batch-reads
branch
from
79eac81 to
196d999
Compare
tdanylchuk
reviewed
Sep 25, 2019
...orage-backend/src/main/java/com/playtika/janusgraph/aerospike/operations/ReadOperations.java
Outdated
Show resolved
Hide resolved
kptfh
force-pushed
the
feature/batch-reads
branch
from
196d999 to
84ca1cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.