Can fd #18
Draft
Can fd #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should be compatible with can; as long as your hw supports this -> maybe autodetect canfd? -> or add a checkbox to the configuration
at least my dbc (-> generated with cantools from an autosar xml) did set the highest bit for can-ids that were bigger then 0x1FF. QCanBus Frame hasExtendedFrameFormat would return true for both cases.
|
I've seen the following fork for CANFD support previously, which is more complete but with also contains some refactorings. I think you can check it for further reference until I got the time for fully reviewing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress: Enable CANFD and extended canIds
Feedback welcome;
ToDo: