-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore original makefiles and not use buildx #35
Conversation
Github action to build from tag |
@DoumanAsh could I kindly ask you to describe obstacles you have with the buildx ? |
@zs-dima Once you setup buildx it fails:
I'm not sure why though, and I don't have ability to figure it out. If you know how to fix it please let me know. |
@DoumanAsh ARM is not supposed by GitHub currently out of the box, let's disable ARM for now. |
a825e8c
to
cdd16ca
Compare
@zs-dima You can try if you can, aarch64 doesn't work itself too |
@DoumanAsh even simpler - just remove ARM option from the buildx configuration |
@DoumanAsh
|
If we remove all arm* variants, there is no point in using buildx |
@DoumanAsh it is point to use buildx as you could back arm easily after this issue is closed, although I do not mind to remove buildx for now. |
cdd16ca
to
163fa75
Compare
Please do not make changes without making sure it would work next time. |
I didn't notice when from buildx came originally but it seems @zs-dima introduced it for regular x86 build, even though it didn't work properly in CI.
So I think it is good to restore it back as it was since @zs-dima introduced new workflow for arm
I'm not sure though why docker buildx doesn't work properly, but I'm unfortunately on windows so I do not have ability to test it locally