Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An attempt to fix disorted submit button on mobile devices like iPhone - please review #370

Merged
merged 3 commits into from
Dec 23, 2018

Conversation

marek-lach
Copy link
Member

No description provided.

@elegaanz elegaanz added C: Bug Something isn't working A: Front-End Related to the front-end labels Dec 23, 2018
@elegaanz
Copy link
Member

@marek-lach Hello! What was the issue you are trying to fix? I can't find anything similar to what you describe in the title…

@codecov
Copy link

codecov bot commented Dec 23, 2018

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files          62       62           
  Lines        5706     5706           
=======================================
  Hits         1625     1625           
  Misses       4081     4081

@marek-lach
Copy link
Member Author

Problem:
When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn't the case on the desktop.

Before pressing the submit button for a comment on an iPhone (though I suspect Android's the same):

img_0551

After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem):
img_0552

I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.

@elegaanz
Copy link
Member

This seems to be related to Safari's rendering engine (I cant' reproduce on my Android phone), and I have no iPhone to test. If it doesn't break anything I'll merge your change, hoping it will fix the issue…

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work: no border is displayed at all… 😕

@marek-lach
Copy link
Member Author

Right, couldn't reproduce the problem on Android. Will try to modify specifically for Safari only then.

@marek-lach
Copy link
Member Author

Hmm... reverted the change and tried a Safari-specific style. Let me know if the border is back as before with this last commit.

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the issue with borders anymore, but I have some other issues, for instance on the user page:

2018-12-23-163432_362x492_scrot

I think this is the same issue as here: https://stackoverflow.com/a/5438653

@marek-lach
Copy link
Member Author

I have reverted all of the changes up to now, and added the suggested webkit-specific fix as advised on stack owerflow. As long as this does not disort anything anywhere else, it might work as a quick solution to the problem for now...

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good now. I hope it will fix your issue.

@elegaanz elegaanz merged commit 2621549 into Plume-org:master Dec 23, 2018
@marek-lach marek-lach deleted the patch-1 branch December 25, 2018 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Front-End Related to the front-end C: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants