-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An attempt to fix disorted submit button on mobile devices like iPhone - please review #370
Conversation
@marek-lach Hello! What was the issue you are trying to fix? I can't find anything similar to what you describe in the title… |
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
=======================================
Coverage 28.47% 28.47%
=======================================
Files 62 62
Lines 5706 5706
=======================================
Hits 1625 1625
Misses 4081 4081 |
This seems to be related to Safari's rendering engine (I cant' reproduce on my Android phone), and I have no iPhone to test. If it doesn't break anything I'll merge your change, hoping it will fix the issue… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work: no border is displayed at all… 😕
Right, couldn't reproduce the problem on Android. Will try to modify specifically for Safari only then. |
Hmm... reverted the change and tried a Safari-specific style. Let me know if the border is back as before with this last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the issue with borders anymore, but I have some other issues, for instance on the user page:
I think this is the same issue as here: https://stackoverflow.com/a/5438653
I have reverted all of the changes up to now, and added the suggested webkit-specific fix as advised on stack owerflow. As long as this does not disort anything anywhere else, it might work as a quick solution to the problem for now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good now. I hope it will fix your issue.
No description provided.