Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login issue #401

Merged
merged 1 commit into from
Dec 31, 2018
Merged

Fix login issue #401

merged 1 commit into from
Dec 31, 2018

Conversation

trinity-1686a
Copy link
Contributor

@trinity-1686a trinity-1686a commented Dec 30, 2018

Fix regression introduced by 80a4dae

Regression introduced by 4059a84
@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #401 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   27.87%   27.88%   +<.01%     
==========================================
  Files          63       63              
  Lines        7254     7252       -2     
==========================================
  Hits         2022     2022              
+ Misses       5232     5230       -2

@igalic
Copy link
Contributor

igalic commented Dec 30, 2018

how'd that happen in? 4059a84

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trinity-1686a
Copy link
Contributor Author

I tagged the wrong commit 😬

@igalic
Copy link
Contributor

igalic commented Dec 30, 2018

that seems more likely
i blame myself for not reading that entire pr 😅

@trinity-1686a trinity-1686a merged commit 2896eb1 into master Dec 31, 2018
@trinity-1686a trinity-1686a deleted the fix-login branch December 31, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants