Fix follow IDs #455
Merged
Fix follow IDs #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elegaanz
added
C: Bug
elegaanz
commented
Feb 27, 2019
| @@ -227,7 +227,6 @@ pub fn update(blog: String, slug: String, user: User, cl: ContentLen, form: Leni | |||
| post.license = form.license.clone(); | |||
| post.cover_id = form.cover; | |||
| post.update(&*conn, &searcher).expect("post::update: update error");; | |||
| let post = post.update_ap_url(&*conn).expect("post::update: update ap url error"); | |||
There was a problem hiding this comment.
Just a note: I removed that without replacing it with something else, since it is incorrect (the AP IDs should change), and was not working anyway (since we were checking if ap_url was empty before updating it, which was only the case on newly created articles).
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
+ Coverage 25.06% 26.48% +1.41%
==========================================
Files 64 64
Lines 6316 7111 +795
==========================================
+ Hits 1583 1883 +300
- Misses 4733 5228 +495 |
trinity-1686a
approved these changes
Mar 4, 2019
| insert!(follows, NewFollow); | ||
| insert!(follows, NewFollow, |inserted, conn| { | ||
| if inserted.ap_url.is_empty() { | ||
| inserted.ap_url = ap_url(&format!("{}/follows/{}", *BASE_URL, inserted.id)); |
There was a problem hiding this comment.
this route should really get implemented one day
There was a problem hiding this comment.
Yes, I think we already have an issue for it…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the syntax of the
insert!macro, allowing to modify an object just after it was saved to the database. You can now optional pass it a "closure" (actually it just looks like a closure) that will be run just after the insertion.I updated all the models, including Follow, to use it to generate AP ID and URL. The advantages are that the ID/URL are now correct (fixes #449) and that we don't have methods like
update_boxesorupdate_ap_urlto call manually and that were easy to forget.