Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin translations #479

Merged
merged 733 commits into from
Apr 19, 2019
Merged

New Crowdin translations #479

merged 733 commits into from
Apr 19, 2019

Conversation

elegaanz
Copy link
Member

Enjoy!

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #479 into master will decrease coverage by 17.58%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #479       +/-   ##
===========================================
- Coverage   42.48%   24.89%   -17.59%     
===========================================
  Files          68       65        -3     
  Lines        9314     7174     -2140     
===========================================
- Hits         3957     1786     -2171     
- Misses       5357     5388       +31

@elegaanz
Copy link
Member Author

OK… I guess I'll leave this PR open. 🤷‍♀️

@elegaanz elegaanz added C: Enhancement New feature or request A: I18N Translations, and related code labels Mar 15, 2019
@elegaanz elegaanz added this to the Alpha 2 milestone Mar 15, 2019
trinity-1686a
trinity-1686a previously approved these changes Mar 15, 2019
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that there is much to approve actually

@igalic
Copy link
Contributor

igalic commented Mar 15, 2019

can someone explain how this works, and why some of it is failing?

@trinity-1686a
Copy link
Contributor

This is a bot committing translations from Crowdin via Bat's account, and all failing commits are actually builds that got canceled because a newer commit arrived before the build started processing

@marek-lach marek-lach added the S: Incomplete This PR is not complete yet label Apr 1, 2019
@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #479 into master will increase coverage by 3.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
+ Coverage    40.9%   44.69%   +3.78%     
==========================================
  Files          68       68              
  Lines        9817     9961     +144     
==========================================
+ Hits         4016     4452     +436     
+ Misses       5801     5509     -292

@elegaanz elegaanz merged commit 68dd860 into master Apr 19, 2019
@elegaanz elegaanz deleted the l10n_master branch April 19, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: I18N Translations, and related code C: Enhancement New feature or request S: Incomplete This PR is not complete yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants