Caching #480
Merged
Caching #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinity-1686a
added
C: Enhancement
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
- Coverage 27.13% 26.82% -0.32%
==========================================
Files 64 64
Lines 7337 7423 +86
==========================================
Hits 1991 1991
- Misses 5346 5432 +86 |
elegaanz
reviewed
Mar 16, 2019
build.rs
Outdated
| @@ -1,8 +1,39 @@ | |||
| extern crate plume_common; | |||
There was a problem hiding this comment.
You should probably remove it from Cargo.toml too.
There was a problem hiding this comment.
I totally forgot about that
trinity-1686a
added
S: Ready for review
elegaanz
reviewed
Mar 16, 2019
| impl<'r> Responder<'r> for Ructe { | ||
| fn respond_to(self, r: &Request) -> response::Result<'r> { | ||
| //if method is not Get or page contain a form, no caching | ||
| if r.method() != Method::Get || self.0.windows(6).any(|w| w == b"<form ") { |
There was a problem hiding this comment.
Probably obvious, but why do we disable caching on pages with a form?
There was a problem hiding this comment.
If the page contain a form, the csrf token will be cached, and may no longer match user's cookies. As these tokens are added later by a fairing, there is no way to detect the page changed here. The other solution could be to allow caching of page and for rocket_csrf to remove ETag when appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to cache static resources.
Static non media file's timestamps are hashed at compile tome so that modifying them invalidate old cache.
For some reason, plume-front.wasm isn't loaded from cache, even if it contains the right headers.I changed nothing and now it is? I guess I'm ok with it
I'll look into adding Etag support tooAll response made from templates and not containing a form are now Etag-cached