Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard smallest screen is 600px #520

Merged
merged 3 commits into from
Apr 8, 2019

Conversation

marek-lach
Copy link
Member

@marek-lach marek-lach commented Apr 8, 2019

For devices that have a screen size so small they have to use the max-width property in CSS, the standard of a screen-size that has to be used here is phones 600px and smaller, not 900px, which would have to use the min-width property instead, that would mean a widescreen size, because min-width means a screen size of 900px, or more, including desktops.

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #520 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
+ Coverage   29.55%   29.66%   +0.11%     
==========================================
  Files          66       66              
  Lines        7190     7190              
==========================================
+ Hits         2125     2133       +8     
+ Misses       5065     5057       -8

@elegaanz elegaanz self-requested a review April 8, 2019 17:32
@elegaanz elegaanz added A: Front-End Related to the front-end C: Enhancement New feature or request labels Apr 8, 2019
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably update it in _header.scss, line 91, otherwise it gives weird results.

image

@marek-lach
Copy link
Member Author

marek-lach commented Apr 8, 2019

Woops, missed that. Fixed now. Curious to see how it'll turn out now :-). Thanks for reviewing!

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@elegaanz elegaanz merged commit de296b6 into master Apr 8, 2019
@elegaanz elegaanz deleted the standard-smallest-screen-is-600px branch April 8, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Front-End Related to the front-end C: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants